ViewRootImpl$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views.

[sentry-io]

Sentry Issue: WORDPRESS-ANDROID-2Y5B

ViewRootImpl$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views.
    at org.wordpress.android.login.LoginBaseFormFragment.endProgress(LoginBaseFormFragment.java:273)
    at org.wordpress.android.ui.accounts.signup.SignupEpilogueFragment.access$200(SignupEpilogueFragment.java:103)
    public class SignupEpilogueFragment extends LoginBaseFormFragment<SignupEpilogueListener>
    at org.wordpress.android.ui.accounts.signup.SignupEpilogueFragment$13.onError(SignupEpilogueFragment.java:752)
    endProgress();
...
(20 additional frame(s) were not displayed)

[dangermattic]

Thanks for reporting! 👍

[thomashorta]

@maxme, I did a quick investigation about this issue and it looks like the new Gravatar-related code, introduced by you in #20590, is causing this crash in WordPress 24.7, which currently seems to have affected only a few users.

I am adding you as an assignee but feel free to assign someone else if it makes sense.

What I believe to be the root cause of the issue is that the AvatarService.upload method runs inside a coroutine in a background thread and also calls the callbacks from GravatarListener from within that background thread, but endProgress called by both callbacks needs to run on the UI thread, and the thread is not being switched anywhere.

WordPress-Android/WordPress/src/main/java/org/wordpress/android/ui/accounts/signup/SignupEpilogueFragment.java

Lines 740 to 758 in 9eb8430

	public void onSuccess(@NonNull Unit response) {
	endProgress();
	AnalyticsTracker.track(Stat.ME_GRAVATAR_UPLOADED);
	mPhotoUrl = WPAvatarUtils.rewriteAvatarUrl(mAccount.getAccount().getAvatarUrl(),
	getResources().getDimensionPixelSize(R.dimen.avatar_sz_large));
	loadAvatar(mPhotoUrl, filePath);
	mHeaderAvatarAdd.setVisibility(View.GONE);
	mIsAvatarAdded = true;
	}
	@Override
	public void onError(@NonNull ErrorType errorType) {
	endProgress();
	showErrorDialogWithCloseButton(getString(R.string.signup_epilogue_error_avatar));
	Map<String, Object> properties = new HashMap<>();
	properties.put("error_type", errorType);
	AnalyticsTracker.track(AnalyticsTracker.Stat.ME_GRAVATAR_UPLOAD_EXCEPTION, properties);
	AppLog.e(T.NUX, "Uploading image to Gravatar failed");
	}

A couple of quick fix suggestions I could think of are:

1. Use getActivity().runOnUiThread in the WP-Android-side around any parts of callback code that interact with the UI (endProgress, setVisibility, etc)
2. Make changes in the Gravatar-SDK-Android AvatarService to always call listener callbacks in the UI thread, which is usually the expected behavior in APIs than own their background execution (something like using withContext(Dispatchers.Main) around the code that calls onSuccess andonError).

Anyway, these are just suggestion I could come up with after doing a quick investigation, so feel free to ignore them if it doesn't make sense as well.

[maxme]

Thanks @thomashorta for investigating, yeah I think having onSuccess and onError running on the main Android thread is best, I'll fix it in a 0.2.1 release of gravatar.

[sentry-io]

Sentry Issue: JETPACK-ANDROID-R1X

[sentry-io]

Sentry Issue: JETPACK-ANDROID-R3V