Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow established Terraform patterns for panel-exchange-client #1078

Open
SanjayVas opened this issue Jun 23, 2023 · 0 comments
Open

Follow established Terraform patterns for panel-exchange-client #1078

SanjayVas opened this issue Jun 23, 2023 · 0 comments

Comments

@SanjayVas
Copy link
Member

SanjayVas commented Jun 23, 2023

After the panel-exchange-client repo merge, the panel-exchange-client Terraform configs live under src/main/terraform/panel-match. They should be merged into the current repo structure under src/main/terraform/gcloud or src/main/terraform/aws. Modules go under the modules subdirectory of each of those respective paths.

In addition, the panel-exchange-client Terraform configurations should be updated to follow the same principles/patterns:

  • Terraform modules should be configurable for any environment.
    • This means machine types, project names, etc. should be specified via configuration variables.
  • Terraform is only used to manage cloud project infrastructure, not Kubernetes objects
    • The one exception is for Kubernetes service accounts due to the tight coupling with cloud IAM. See the corresponding documentation for Google Cloud and AWS
  • Terraform configurations can be applied without using Bazel to build anything.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant