Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llv2 and rollv2 may report wrong reach if the aggregator crashes right before sending reach result to kingdom #1179

Open
ple13 opened this issue Aug 21, 2023 · 0 comments
Assignees
Labels
bug Something isn't working
Projects

Comments

@ple13
Copy link
Contributor

ple13 commented Aug 21, 2023

Describe the bug
In the reach only and reach & frequency protocols, the aggregator first initializes the reach with 0L. It then runs an existOutputOr block to compute the next token. Inside this block, if the output blob is empty, it updates the reach and writes stuff to the output blob. Otherwise, it skips the block, and sends the reach to the kingdom.

There is a problem when the output blob exists, but the aggregator crashes before sending the reach to the kingdom. As the existOutputOr block is skipped, the reach will not be updated and will stay at the initialized value (0L). As a result, the kingdom will receive 0L.

Steps to reproduce
This is not reproducible as there are no tests to catch the possible issue yet.

Component(s) affected
Duchy (aggregator)

Version
NA

Environment
NA

Additional context
https://github.com/world-federation-of-advertisers/cross-media-measurement/blob/main/src/main/kotlin/org/wfanet/measurement/duchy/daemon/mill/liquidlegionsv2/LiquidLegionsV2Mill.kt#L704

https://github.com/world-federation-of-advertisers/cross-media-measurement/blob/main/src/main/kotlin/org/wfanet/measurement/duchy/daemon/mill/liquidlegionsv2/ReachOnlyLiquidLegionsV2Mill.kt#L596

@ple13 ple13 added the bug Something isn't working label Aug 21, 2023
@ple13 ple13 self-assigned this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Panels
Awaiting triage
Development

No branches or pull requests

1 participant