Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate internal streaming RPC overhead for List methods #1217

Open
SanjayVas opened this issue Sep 11, 2023 · 0 comments
Open

Investigate internal streaming RPC overhead for List methods #1217

SanjayVas opened this issue Sep 11, 2023 · 0 comments
Labels
internal cleanup Internal improvements to code that may not be apparent in external interfaces

Comments

@SanjayVas
Copy link
Member

SanjayVas commented Sep 11, 2023

Originally brought up by @tristanvuong2021.

We may be paying an unnecessarily penalty for our use of server streaming for the internal service methods that support public List methods. Server streaming has extra communication overhead for each response. The response type for these is the entity that maps to the public API resource, meaning there is one RPC response per resource. If the only caller is a List method, then we're not gaining any benefits of streaming as the result will be fully collected in order to build the public API response.

Effectively using the resource as our internal response type also means that we have to request one extra response from the internal service in order to determine whether to set the next_page_token field in the public response.

@SanjayVas SanjayVas added the internal cleanup Internal improvements to code that may not be apparent in external interfaces label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal cleanup Internal improvements to code that may not be apparent in external interfaces
Projects
None yet
Development

No branches or pull requests

1 participant