Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDPs should return ProtocolConfig to the Duchy to verify #1329

Open
renjiezh opened this issue Nov 9, 2023 · 0 comments
Open

EDPs should return ProtocolConfig to the Duchy to verify #1329

renjiezh opened this issue Nov 9, 2023 · 0 comments
Assignees
@renjiezh
Labels
enhancement New feature or request

Comments

@renjiezh
Copy link
Contributor

renjiezh commented Nov 9, 2023 •
edited

Describe the bug
Among requisition fulfillment, the duchy should verify the ProtocolConfig from EDP to ensure both of them are using the exactly same ProtocolConfig.

The Kingdom assigns ProtocolConfig for every Computation. But EDPs receive the ProtocolConfig from the requisition list and Duchies receive ProtocolConfig from the measurement. It is possible that Kingdom provides two different ProtocolConfigs. Duchies and EDPs need the verification to match their ProtocolConfigs.

Component(s) affected
EDPs, EDP simulator, Duchy.

Potential Solution
EDP/EDP simulator: Fulfill requisitions along with entire ProtocolConfig or a fingerprint. Due the the nature of non-deterministic protobuf serialization, we need a sophisticated approach to generate the fingerprint.
Duchy: Compare ProtocolConfig or fingerprint in requisition requests with ProtocolConfig of computations.

Version
Environment
Additional context
@renjiezh renjiezh added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Nov 9, 2023
@renjiezh renjiezh self-assigned this Nov 9, 2023
@renjiezh renjiezh mentioned this issue Nov 20, 2023
Merged
renjiezh added a commit to world-federation-of-advertisers/cross-media-measurement-api that referenced this issue Nov 28, 2023
@renjiezh
Update FulfillRequisitionRequest and ProtocolConfig for ShuffleBasedS…
3da36d7 
…ecretSharing protocol (#191)

For shuffle based secret sharing protocol, requisitions are fulfilled by
EDPs with either chunks of data (a blob) or a seed. The seed can be
expanded into a deterministic blob with the same PRNG by workers.
The change is back-compatible.

Also added ProtocolConfig in FulfillRequisitionRequest for this
issue(world-federation-of-advertisers/cross-media-measurement#1329).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@renjiezh renjiezh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@renjiezh