Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from Java protobuf to Kotlin protobuf #80

Closed
SanjayVas opened this issue May 26, 2021 · 2 comments
Closed

Migrate from Java protobuf to Kotlin protobuf #80

SanjayVas opened this issue May 26, 2021 · 2 comments
Labels
good first issue Good for newcomers

Comments

@SanjayVas
Copy link
Member

There is now Kotlin-specific protobuf code generation as of protocolbuffers/protobuf#8272. We need not migrate everything to the new DSL builder syntax at once, but we should use Bazel rules that generate Kotlin protobuf code. We'll need to figure out if there are any pending issues related to how this interacts with grpc-kotlin.

See https://developers.google.com/protocol-buffers/docs/reference/kotlin-generated.
@SanjayVas SanjayVas added the good first issue Good for newcomers label May 26, 2021
@SanjayVas
Copy link
Member Author

This might be blocked on grpc-kotlin and/or rules_kotlin getting updated to use the new protoc extensions.

@SanjayVas
Copy link
Member Author

Closed by #202.

renjiezh pushed a commit that referenced this issue Feb 7, 2022
@stevenwarejones
build query outputs query id to ids map (#80)
264f89b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SanjayVas