Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctness tests fails when there are no events #953

Open
SanjayVas opened this issue Apr 18, 2023 · 0 comments
Open

Correctness tests fails when there are no events #953

SanjayVas opened this issue Apr 18, 2023 · 0 comments
Labels
bug Something isn't working triaged Has been triaged by Halo eng

Comments

@SanjayVas
Copy link
Member

When there are no events which match filtering predicates in the data set, the correctness test fails for MPC-based R/F measurements. The expected result computed from the unencrypted sketches is always

reach {
  value: 1
}
frequency {
}

This is not considered within the tolerance range compared to an MPC result.

Sample result:

reach {
  value: 6
}
frequency {
  relative_frequency_distribution {
    key: 1
    value: 0.16129032258064516
  }
  relative_frequency_distribution {
    key: 5
    value: 0.44623655913978494
  }
  relative_frequency_distribution {
    key: 7
    value: 0.010752688172043012
  }
  relative_frequency_distribution {
    key: 8
    value: 0.03763440860215054
  }
  relative_frequency_distribution {
    key: 9
    value: 0.3225806451612903
  }
  relative_frequency_distribution {
    key: 10
    value: 0.021505376344086023
  }
}
@SanjayVas SanjayVas added bug Something isn't working triaged Has been triaged by Halo eng labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged Has been triaged by Halo eng
Projects
None yet
Development

No branches or pull requests

1 participant