Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it works with film title written in other languages? #27

Open
roccomuso opened this issue Oct 23, 2016 · 11 comments
Open

Does it works with film title written in other languages? #27

roccomuso opened this issue Oct 23, 2016 · 11 comments

Comments

@roccomuso
Copy link

Would it be difficult to implement some kind of i18n?
It seems to be working just with movies given his english title.

@worr
Copy link
Owner

worr commented Nov 15, 2016

Unfortunately, this isn't available in the upstream API that I'm using.

@sunsgs
Copy link

sunsgs commented Jan 16, 2017

@roccomuso you can translate it before to use the api, in the most of cases you can get the right english title

@roccomuso
Copy link
Author

@sunsgs Most of the time translations are completly different, just because they tend to change meanings avoiding literal translation, it wouldn't work.

@daviestar
Copy link

daviestar commented Jan 24, 2017

The Movie DB has an 'AlternativeTitles' endpoint which you could potentially use for i18n.

https://github.com/impronunciable/moviedb/blob/v0.2.0/lib/endpoints.json#L34

Once you have the correct imdb id you can use this package to get the metadata.

@damru
Copy link

damru commented May 18, 2017

Hi,

It is possible by changing the headers during the execution of "request"
eg to force english language :
request({headers: {'Accept-Language': 'en-US'}, uri: 'http://www.imdb.com/title/' + id + '/'}, function (error, response, body)

@roccomuso
Copy link
Author

@damru let me better understand. If you provide the Accept-Language header, the IMDB engine will search the record in a different language? Is this confirmed?

@damru
Copy link

damru commented May 19, 2017

@roccomuso exactly.
Basically, IMDB provides the information depending on your location. So if you are in France for example, it will provides the French title (which can be the same as the original, it is not a simple translation).
And changing the headers fakes this location, so you can retrieve information in the language you want.

@roccomuso
Copy link
Author

Definetly a wanted feature.

@worr
Copy link
Owner

worr commented May 19, 2017

Cool, thanks for the input. I'll explore this as soon as I get time.

@worr worr added the omdb label May 19, 2018
@svzi
Copy link

svzi commented Aug 10, 2018

@worr Any update on this topic?

@fatshotty
Copy link

hi, any news about accept-language request header?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants