Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX fix season numbers for Episodes #73

Closed
wants to merge 1 commit into from
Closed

BUGFIX fix season numbers for Episodes #73

wants to merge 1 commit into from

Conversation

js-kyle
Copy link

@js-kyle js-kyle commented Apr 19, 2020

No description provided.

@js-kyle
Copy link
Author

js-kyle commented Apr 28, 2020

@worr Would there be any chance of a merge & npm publish for this one? Thank you

@worr
Copy link
Owner

worr commented May 1, 2020

@js-kyle Sorry, been a rough few weeks here for me.

You have a build failure from not including the radix in the call to parseInt. I'd also like a test with an invalid number (since the api I use can sometimes return invalid data).

https://travis-ci.org/github/worr/node-imdb-api/jobs/676757957

@js-kyle
Copy link
Author

js-kyle commented May 1, 2020

No problem, hope things work out.

I'll take a look at those things - sorry, didn't even check the build for the PR

@worr worr closed this in 2874784 Jun 29, 2020
@worr
Copy link
Owner

worr commented Jun 29, 2020

It looks like there was no update here, so I've resolved it myself. Thanks for the attempt.

@js-kyle
Copy link
Author

js-kyle commented Jun 29, 2020

@worr Sorry - this fell off my radar. Thanks heaps for your time in picking the issue up, and the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants