New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include more functional migrator tests #38

Open

wouterj opened this issue Nov 9, 2016 · 2 comments

Owner

wouterj commented Nov 9, 2016

E.g. to catch errors like #37

Contributor

theofidry commented Nov 9, 2016

I think this can be detected by having a functional test doing:

1 migration to create a table => check the table existence
populate the table => check the number of persisted entities
reset the migration => check the table (non) existence

Owner Author

wouterj commented Nov 9, 2016

At the moment (1) and (2) is already covered: https://github.com/wouterj/WouterJEloquentBundle/blob/master/tests/Functional/MigrationsTest.php

So we just need to extend this with (3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment