-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video stream reader issue #62
Comments
Thanks for the report - I currently do not have access to my windows machine, but will investigate when I get it back (will be a couple of weeks though). In the meantime: could you try on a previous nodejs / electron version and see if you get the same behaviour? |
Sorry for the long time it took - do you still have this issue with the latest version of this module? (v0.2.2) |
i'd need to try it again, coming back when i've done it ;) |
Yes, the issue persists with v0.2.2 (run with the latest nodejs). btw I wonder why Electron handles video stream demos gracefully, whereas nodejs + express + browser html cannot. |
actually I just got this solved. wouterverweirder is right - try a previous nodejs version. In my case I tried v8.17.0 as it is the earliest nodejs that supports napi 4 (which is required for this module to work). |
Well, i understand but isn't it kind of a problem to have to downgrade your node to run a program (isn't it more standard to have the program updated for the newest versions) ? |
Stick to the electron demos if you want to use the latest nodejs. Somehow running openColorReader/openDepthReader/etc inside the electron framework does not trigger the same issue as in bare nodejs -- I wonder why, though. You might also consider running multiple nodejs versions on your machine. |
I've just pushed an update to the way prebuild binaries are handled - could you try v0.2.3 and see if the error persists? The whole idea of napi is to be future compatible. I've tested on node v14 as well, and it is working on my end. If not: could you post your CLI log of what happens when you npm install? |
hi there, thx 4 the update! I've just tried v0.2.3 with two latest versions of nodejs (v14 and v16). The 'test.js' file you've just included works fine, until commenting out the following codes:
Then 'fatal error' comes up again, which is like
in node v14.17.3, and
in node v16.4.2. These error reports are exactly the same as in kinect2 v0.2.2 except for the 16 digits in '#FailureMessage Object: XXXX XXXX XXXX XXXX' which always differ in each test. The key issue is that both kinect2 v0.2.2 and v0.2.3 work fine to read ONE SINGLE FRAME, be it depth frame or color frame etc. I tested for many times and found that v0.2.2 can read and log an entire color frame (8294400 bytes long) or depth frame (217088 bytes), and calmly exit (by calling process.exit() after reading one frame) without reporting an error. It is when programmed to read more than two frames that error reports occur, not to mention continuously read. Interestingly, the same codes that produce fatal errors in bare nodejs work perfectly in electron. |
Looks like there were some changes in the way buffers are handled in node 14 (nodejs/node#32463) I've made some changes and pushed a new version 0.2.4: https://github.com/wouterverweirder/kinect2/releases/tag/v0.2.4 - hopefully this fixes the issues on your end |
hi wouterverweirder, I just tested your new package on node-14.17.6 and node-16.9.0, both worked perfectly, with new console lines:
(in the case of node-16.9.0, it's node:13876 instead of node:5572) Your project is of great value to me, and I would like to donate 10 euros as a small token of gratitude. However, I failed to make a donation because of country restriction (I'm currently in China). Please tell me if there is any alternative donation methods that are available; or I might ask if any of my friends in EU would like to help. Thanks again for the excellent project! |
hi a friend of a friend of mine has just made a pay-pal transfer (email: For**88@live.com). thx again for the excellent project, I've learnt a great deal from it. |
Glad to hear this issue is fixed & thanks a lot for the donation! Appreciated :-) |
Opening a video stream (Depth, Infrared, Color) rises a
Fatal error
issue:here is the code used
Systems info:
Error produced:
All these methods fail to open and rises this error
The only working opener is
The text was updated successfully, but these errors were encountered: