Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add Icon, if it has dropdown menu? #415

Open
nriddhi opened this issue Feb 17, 2019 · 2 comments
Open

How to add Icon, if it has dropdown menu? #415

nriddhi opened this issue Feb 17, 2019 · 2 comments

Comments

@nriddhi
Copy link

nriddhi commented Feb 17, 2019

I am making a menu with dropdown, how can i add after menu name a font awesome dropdown icon, if it has dropdown menu

<li class="nav-item drop_menu"> <a class="nav-link" href="#">Services <i class="fas fa-caret-down"></i></a>
  <ul> <li><a href="service.html">Service main</a></li>
           <li><a href="service-single.html">Service single</a></li>
 </ul>
 </li>
@pattonwebz
Copy link
Member

Hey @nriddhi,

I am sorry to say that I have not added a way to add icons AFTER items in the menu (even if they have no dropdown attached). The icon support here is added BEFORE items only.

I realise that adding them after items may be a better option so I will investigate that and try to find a solution. Thank you for highlighting the missing feature.

@pattonwebz pattonwebz self-assigned this Feb 28, 2019
@pattonwebz pattonwebz added this to To do in Walker v5 via automation Feb 28, 2019
@IanDelMar
Copy link
Collaborator

@pattonwebz I don't know whether I got @nriddhi right but what they ask for is default Bootstrap behavior, no? There was a bug preventing the caret to show up (see #435) which was fixed in #481. I don't see how to implement this feature without a) adding inline styles or b) enqueueing a CSS file. I don't think this feature is important enough to justify adding CSS (which can easily be done by users themselves), especially because the feature only provides styles but no functionality and hence can be removed from the v5 todo list.

@nriddhi If you really want to use a Font Awesome icon instead of the default caret you can achieve this by overwriting the CSS for the default caret. Have a look at this comment for guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Walker v5
  
To do
Development

No branches or pull requests

3 participants