Skip to content
This repository has been archived by the owner on Nov 15, 2020. It is now read-only.

Uri too long #24

Open
TylerBarnes opened this issue Feb 25, 2020 · 3 comments
Open

Uri too long #24

TylerBarnes opened this issue Feb 25, 2020 · 3 comments
Assignees
Labels

Comments

@TylerBarnes
Copy link

Some servers will error if the URI is too long. Since the query is encoded into the url, this will sometimes be problematic.
When the query is removed from the url, the query still loads into the page. I assume from local storage. Is there a reason to encode the query in the url?

@jasonbahl
Copy link
Contributor

jasonbahl commented Feb 25, 2020

@TylerBarnes I believe the reason to encode it in the url was to make it shareable. I could copy the URL, share it with someone else, and when they paste it the query / mutation would be in GraphiQL for them to execute.

@jasonbahl
Copy link
Contributor

If I'm not mistaken, @henrikwirth borrowed code from Gatsby's implementation of GraphiQL. So if this is buggy behavior, there's a chance that Gatsby also has some buggy behavior. Might be worth checking Gatsby to make sure (or borrow more code if it's fixed over there 😄)

@jasonbahl jasonbahl added the bug label Feb 25, 2020
@TylerBarnes
Copy link
Author

Ah, makes sense. Maybe we should just set a reasonable upper limit on that then

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants