Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False Positive: Revive Old Posts plugin #254

Open
DougNix opened this issue Dec 24, 2019 · 1 comment
Open

False Positive: Revive Old Posts plugin #254

DougNix opened this issue Dec 24, 2019 · 1 comment

Comments

@DougNix
Copy link

DougNix commented Dec 24, 2019

Please add this to the False Positives list.

Revive Old Posts by revive.social, https://wordpress.org/plugins/tweet-old-post/, generates the following errors:

FILE: /home/ms101admin/public_html/wp-content/plugins/tweet-old-post/vendor/facebook/graph-sdk/src/Facebook/PseudoRandomString/McryptPseudoRandomStringGenerator.php

FOUND 3 ERRORS AFFECTING 1 LINE

57 | ERROR | Function mcrypt_create_iv() is deprecated since PHP 7.1 and removed since PHP 7.2; Use random_bytes() or OpenSSL instead
57 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
57 | ERROR | The constant "MCRYPT_DEV_URANDOM" is deprecated since PHP 7.1 and removed since PHP 7.2

According to the authors, this is a false positive. https://wordpress.org/support/topic/php-7-3-compatibility-22/#post-12267591

@UVLabs
Copy link

UVLabs commented Dec 24, 2019

The error is coming from the Facebook graph SDK which is a dependency of the plugin: https://github.com/facebook/php-graph-sdk/tree/5.x/src/Facebook/PseudoRandomString

Unless they update their SDK everyone using their SDK would get this error. The plugin doesn't necessarily make use of those functions, they just happen to be part of the Facebook SDK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants