Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Swerve Simulation Support Status #2406

Open
jasondaming opened this issue Nov 26, 2023 · 4 comments
Open

Update Swerve Simulation Support Status #2406

jasondaming opened this issue Nov 26, 2023 · 4 comments
Assignees

Comments

@jasondaming
Copy link
Member

This article references this PR which has been closed. We should update it to reflect our current thoughts on swerve simulation.

IMO we should think about including "perfect" swerve simulation. While it isn't accurate for testing real world effects of swerve it is extremely useful for testing things like basic driver control and automated pathing.

@virtuald
Copy link
Member

FWIW pyfrc's physics module includes a 'perfect' four motor swerve drivetrain object for simulation. https://github.com/robotpy/pyfrc/blob/b8472df58739031b60c384f3304c6cb56e582f19/pyfrc/physics/drivetrains.py#L318

@calcmogul
Copy link
Member

calcmogul commented Nov 26, 2023

That looks like what the SwerveDriveKinematics class already does.

@jasondaming
Copy link
Member Author

Are you talking about this?

Are you just saying that all of the "math" is already there?

I was suggesting that there should be a SwerveDrivetrainSim similar to how there is a DifferentialDrivetrainSim

@calcmogul
Copy link
Member

Are you just saying that all of the "math" is already there?

Yes.

I was suggesting that there should be a SwerveDrivetrainSim similar to how there is a DifferentialDrivetrainSim

We could, though it'll just be a thin wrapper around SwerveDriveKinematics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants