Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️Contributing to frc-docs✏️ #812

Open
Daltz333 opened this issue Aug 27, 2020 · 2 comments
Open

✏️Contributing to frc-docs✏️ #812

Daltz333 opened this issue Aug 27, 2020 · 2 comments

Comments

@Daltz333
Copy link
Member

Daltz333 commented Aug 27, 2020

Thank you for contributing to frc-docs and the WPILib project 😄

The first thing is to familiarize yourself with the Contribution Guidelines. These set of articles guide you through getting a build environment setup and familiar with the style used in the frc-docs project. Additionally, documentation is written with reStructuredText, an advanced markup ✏️ language.

Once you're familiar with how the project is structure, take a look at the Github Issues. These issues are marked with various labels to easier organize things. Here is a cheat sheat:

  • Addition - Minor addition to an existing article
  • Help Wanted - Used to describe issues that require a bit more knowledge of the project/WPILib and need extra attention
  • Good First Issue - Is used to mark issues that can be solved with relatively simple additions, such as a small content blurb or change.
  • Contributors Welcome - Mostly all issues are open to contributors. Issues completely open for consideration and not following under other categories are labelled with this. Some issues require additional discussion, so we'd like you to hold off 🛑 until we can work out the implementation
  • Component: X - This PR or issue affects a certain component of the WPILib software suite
  • Needs Design Decision - This is used for controversial content, or content that needs conversation on the correct implementation or solution. You are welcome to comment on the issue with your thoughts.
  • Waiting on: WPILib - We're waiting on something to get implemented or released in WPILib
  • Waiting on: Dependency - Waiting on some sort of external dependency before we can move forward
  • Waiting on: FIRST - Waiting for an official decision for FIRST. This is used for content that requires HQ approval before merge.
  • High Priority - This is used to signify issues of the utmost importance. These issues should get solved ASAP.
  • i18n - This is used to mark something that is related to translating or translation.
  • Type: Structure - This is used to mark something related to configuration or structure of the repository.
  • Type: Cleanup - General cleanup of the repo or content
  • Type: Style/CSS - Changes made to the style of the website. This will usually coincide with a Waiting on: FIRST label.
  • Type: Configuration - Changes made to the configuration of the project; CI, Build, Extensions, etc.
  • Examples - Highlights a change to an example somewhere
  • Component: XY - What category of content is being changed

Additionally, as mentioned in the contribution guidelines, hardware PRs can often require approval from FIRST. Please be patient as this can require an extended period of time before merge.

Sometimes a PR can get loss in the abyss 🏃 (forgotten about) and needs review from a repository maintainer. If that's the case, feel free to ping @wpilibsuite/documentation for further review. Be gentle with the pings, as many of us have full-time jobs alongside our volunteer work with WPILib.

Lastly, PRs need to be kept up-to-date. This includes merging/rebasing master back into your branch, and addressing any review comments given. PRs can be closed if stale, to signify that the issue is still open for contributors.

@Daltz333 Daltz333 pinned this issue Aug 27, 2020
@Daltz333 Daltz333 changed the title Contributing to frc-docs ✏️Contributing to frc-docs✏️ Aug 27, 2020
@samneff72
Copy link
Contributor

I've done my Continuous Integration checks inside GitHub after uploading, rather than in a local code editor, which is inefficient.

If I load the entire repo into VSCode, do the CI checks come with it? I tried opening the frc-docs folder, which shows a Makefile exists at the top level, but if I just use the command Run Build Task then I get nothing, it asks me to Configure Build Task.
(I didn't try to run the WPI Build Robot Code function, figure it'll be same or worse.)

Is there a Read-The-Docs on Read-The-Docs that will get me going that we can link to here, or are there repo-specific instructions that I need to follow?

@sciencewhiz
Copy link
Collaborator

Is there a Read-The-Docs on Read-The-Docs that will get me going that we can link to here, or are there repo-specific instructions that I need to follow?

https://docs.wpilib.org/en/stable/docs/contributing/frc-docs/build-instructions.html

This is an article in the contributing guidelines linked above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants