Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No red highlight for too big asset in request monitoring #602

Open
basia-wulnikowska opened this issue Nov 26, 2020 · 1 comment
Open

No red highlight for too big asset in request monitoring #602

basia-wulnikowska opened this issue Nov 26, 2020 · 1 comment
Assignees
Labels
bug size small Quick fixes and minimal-effort issues

Comments

@basia-wulnikowska
Copy link
Contributor

Describe the bug
In new feature request monitoring, we've got option to choose max size of assets and if they're bigger - they are listed with some highlight. Currently there is no red highlight for biggest asset that is too big. Check screenshot (first file is too big here).
2020-11-24_13h55_41

@basia-wulnikowska basia-wulnikowska added bug size small Quick fixes and minimal-effort issues labels Nov 26, 2020
@basia-wulnikowska basia-wulnikowska added this to To do in AET Summer 2020 via automation Nov 26, 2020
@basia-wulnikowska basia-wulnikowska moved this from To do to In progress in AET Summer 2020 Nov 27, 2020
@basia-wulnikowska
Copy link
Contributor Author

IMPORTANT: After discussion we understood, that currently request monitoring only checks all assets total size and is basing on it. We agreed that checking max size for each specific item would also be good improvement for this feature. Additional code is being added to request monitoring. When functionality of checking maxSize for items will be implemented on backend, we only need to uncomment the code and this should work.

@basia-wulnikowska basia-wulnikowska moved this from In progress to To do in AET Summer 2020 Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug size small Quick fixes and minimal-effort issues
Projects
Development

No branches or pull requests

2 participants