Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Github Actions #631

Open
6 tasks done
devzbysiu opened this issue Feb 26, 2021 · 5 comments
Open
6 tasks done

Move to Github Actions #631

devzbysiu opened this issue Feb 26, 2021 · 5 comments
Assignees
Labels
enhancement size medium Issues that would require some thinking and tinkering to fix

Comments

@devzbysiu
Copy link
Contributor

devzbysiu commented Feb 26, 2021

Is your feature request related to a problem? Please describe.
In a process of modernizing CI/CD, we are going to move from Jenkins + Travis (for checks), to Github Actions.

Describe the solution you'd like
What should be done in Github Actions:

  • PR cannot be merged until checks pass, checks should run test and license validation via RAT
  • after the merge, CI workflow should trigger a build and generate code coverage
  • release workflow should be implemented:
    • updating AET changelog
    • bumping version
    • uploading artifacts to AET Release page
    • creating PR with changelog changes

We should be able to trigger the workflow manually and have control over the version number we are going to release.

Describe alternatives you've considered
N/A

Additional context
N/A

@devzbysiu devzbysiu added enhancement size medium Issues that would require some thinking and tinkering to fix labels Feb 26, 2021
@devzbysiu devzbysiu added this to In progress in AET Summer 2020 Feb 26, 2021
@devzbysiu devzbysiu self-assigned this Feb 26, 2021
@devzbysiu
Copy link
Contributor Author

This is finished developer-wise. The next steps are:

  • take care of internal environment issue in relation to Karaf upgrade #624
  • deploy the release and test it

@devzbysiu
Copy link
Contributor Author

devzbysiu commented Mar 1, 2021

You can find the code coverage here.

You can see the details of the release process here (note: you won't see that unless you can login to our confluence space)

@devzbysiu devzbysiu moved this from In progress to QA Validation in AET Summer 2020 Mar 4, 2021
@pilarskie
Copy link
Collaborator

@devzbysiu Automatic PR failed to trigger check.

@devzbysiu devzbysiu assigned pilarskie and unassigned devzbysiu Mar 12, 2021
@devzbysiu
Copy link
Contributor Author

@pilarskie it's fixed now. The issue was related to the github bot creating a PR. Github actions have a safety net for infinite loop triggered by bots. Because of that, the PR which is created by the bot does not trigger the workflow. The workaround for that is to use an existing user to create a PR.

From the functional perspective, nothing changed. The release is created the same way. After it finishes, the PR should have triggered PR check.

@pilarskie
Copy link
Collaborator

Tested and accepted.

@pilarskie pilarskie moved this from QA Validation to Done in AET Summer 2020 Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement size medium Issues that would require some thinking and tinkering to fix
Projects
Development

No branches or pull requests

2 participants