-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SkiaChart: Texts including axis labels, tooltips, toolbox and legend are not rendered. #174
Comments
use rnsvg or lower version of rnskia |
I switched to SvgChart and it worked, but is there any implication I should be aware of? Thank you. |
Yes, I'm aware. SvgCharts works but it's slow to respond to gestures. That's why I explicitly need SkiaChart to work. |
@nipunadodan yes I am having exactly same issue with you. |
@Jay2009 Below is what we've done as a workaround for now. It's not ideal but might help you (as long as you don't need react-native-skia for anything bar react-native-echarts on iOS). @shopify/react-native-skia 0.1.234 is the last version that will render text in react-native-echarts. That version will crash/lock up an iOS app on RN 0.73.8 (the version of RN we're using, I haven't tried 0.74.x yet) but seems to work fine on Android. We want Skia rendering for slow Android devices as it's faster than SVG rendering. The iOS devices will use SVG rendering for now (since they have generally stronger performance). How to set this up:
module.exports = {
dependencies: {
'@shopify/react-native-skia': {
platforms: {
ios: null
}
}
}
}
const SomeComponent = () => {
const PlatformSpecificChartTag = Platform.OS === 'ios' ? SvgChart : SkiaChart
return <PlatformSpecificChartTag option={...} etc />
} |
Now that react-native-skia have documented that text in ImageSVG tags is not going to be supported could we add that to the known issues on #16? |
Describe the bug
Texts including axis labels, tooltips, toolbox and legend are not rendered.
To Reproduce
Steps to reproduce the behaviour:
Expected behaviour
Texts on axis labels, tooltips, legends and toolbox should be visible.
Screenshots
This is how it looks like when it is rendered using SkiaChart
This is how it is expected to look (screenshot taken after rendered using SVG)
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Sample code: Github gist
The text was updated successfully, but these errors were encountered: