Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve editor traffic lights #540

Closed
sindresorhus opened this issue Sep 27, 2018 · 3 comments
Closed

Improve editor traffic lights #540

sindresorhus opened this issue Sep 27, 2018 · 3 comments
Assignees
@karaggeorge
Labels
Help Wanted Priority: Low Type: Enhancement
Projects
3.0.0
Milestone
3.0.0

Comments

@sindresorhus
Copy link
Member

They look really fake now.

Ours:

screen shot 2018-09-27 at 16 16 12

Real:

screen shot 2018-09-27 at 16 16 29
@skllcrn
Copy link
Member

skllcrn commented Sep 27, 2018 •
edited

I believe these have slightly different styles now too, depending on if you're in Light or Dark mode (#478).

@skllcrn skllcrn added this to the 3.0.0 milestone Sep 27, 2018
@skllcrn skllcrn added this to To do in 3.0.0 Sep 27, 2018
@sindresorhus
Copy link
Member Author

Dark mode vs light mode:

screen shot 2018-09-27 at 16 41 27

screen shot 2018-09-27 at 16 41 17

@sindresorhus
Copy link
Member Author

And this is how a disabled traffic light button looks like:

screen shot 2018-09-27 at 16 50 33

screen shot 2018-09-27 at 16 50 41

@karaggeorge karaggeorge self-assigned this Sep 27, 2018
@karaggeorge karaggeorge mentioned this issue Sep 28, 2018
Merged
@skllcrn skllcrn moved this from To do to Needs review in 3.0.0 Sep 28, 2018
3.0.0 automation moved this from Needs review to Production ready Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karaggeorge karaggeorge

Labels
Help Wanted Priority: Low Type: Enhancement
Projects
No open projects
3.0.0
  
Production ready
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@sindresorhus @skllcrn @karaggeorge