Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedupe wurd-web and wurd-node #3

Open
caub opened this issue Feb 17, 2020 · 0 comments
Open

Dedupe wurd-web and wurd-node #3

caub opened this issue Feb 17, 2020 · 0 comments

Comments

@caub
Copy link
Contributor

caub commented Feb 17, 2020

There seem to be similar stuff between the 2 libs

https://github.com/wurdcms/wurd-node/blob/master/src/block.js#L166

https://github.com/wurdcms/wurd-web/blob/master/src/block.js#L105

I think we could merge them and make sure it works on both node and web (for example we can require('node-fetch') on both node and browser, node-fetch is 'universal' (https://github.com/node-fetch/node-fetch/blob/master/package.json#L6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant