Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marked in peerDepencies, and switch main in package.json to es build #7

Open
caub opened this issue Apr 17, 2020 · 0 comments
Open

Comments

@caub
Copy link
Contributor

caub commented Apr 17, 2020

the problem with https://github.com/wurdcms/wurd-web/blob/master/package.json#L7 is webpack will use this bundle https://github.com/wurdcms/wurd-web/blob/master/dist/wurd.js that already packs marked, so it can duplicate marked if the app is also using marked in its dependencies

We should put marked in peerDependencies, and let webpack pick the ESM build by changing the main entry in package.json

Note: it should also be easy to avoid the get-property-vaue dependency as it's just

const get = (o, path) => path.split('.').reduce((obj, k) => obj[k], o);
caub added a commit to caub/wurd-web that referenced this issue Apr 17, 2020
caub added a commit to caub/wurd-web that referenced this issue Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant