Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

airframe-http: Deprecate HttpFilter[Req, Resp, F[_]] #2921

Open
xerial opened this issue May 3, 2023 · 1 comment
Open

airframe-http: Deprecate HttpFilter[Req, Resp, F[_]] #2921

xerial opened this issue May 3, 2023 · 1 comment
Assignees
@xerial
Labels
kaizen code improvement without changing user-facing functionality
Milestone
Airframe 24

Comments

@xerial
Copy link
Member

xerial commented May 3, 2023

The current request router depends on the legacy interface HttpFitler and HttpBackend, which accept arbitrary Req, Resp, F (Future) types.

Now that we have the standard Request/Response objects and Rx for async interface, no longer need to use these type abstractions and adaptors. The implementation of airframe-http will be much simpler.
@xerial xerial self-assigned this May 3, 2023
@xerial xerial added the kaizen code improvement without changing user-facing functionality label May 3, 2023
@xerial
Copy link
Member Author

xerial commented May 5, 2023 •
edited

This dependency is only airframe-http-finagle, so moving this implementation to airframe-http-finagle can be a safer option without introducing too much breaking changes.

@xerial xerial added this to the Airframe 23 milestone Aug 6, 2023
@xerial xerial modified the milestones: Airframe 23, Airframe 24 Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xerial xerial

Labels
kaizen code improvement without changing user-facing functionality
Projects
None yet
Milestone
Airframe 24
Development

No branches or pull requests
1 participant
@xerial