Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging PR body seems to be buggy when old_body is modified #21

Open
shirakia opened this issue Feb 10, 2018 · 0 comments
Open

Merging PR body seems to be buggy when old_body is modified #21

shirakia opened this issue Feb 10, 2018 · 0 comments

Comments

@shirakia
Copy link

This issue is partially related to #20

Step to reproduce

  1. Do git-pr-release, then the release PR body is
- [ ] #1 Init new func @test_user
- [ ] #2 Add new func @test_user2
  1. Edit PR body like
- [ ] #1 Init new func @test_user
- [ ] #2 Add new func @test_user2

In this PR, we've done blah blah blah ...

When we release, we should do blah blah blah ...
  1. Merge new some PRs into staging branch

  2. Do git-pr-release again

Result

The release PR body is

- [ ] #1 Init new func @test_user
- [ ] #2 Add new func @test_user

- [ ] #3 Fix bugs @test_user
In this PR, we've done blah blah blah ...
- [ ] #4 Add more func @test_user

- [ ] #5 Refactor a bit @test_user
When we release, we should do blah blah blah ...
- [ ] #6 hogehoge @test_user"

Expected results

- [ ] #1 Init new func @test_user
- [ ] #2 Add new func @test_user
- [ ] #3 Fix bugs @test_user
- [ ] #4 Add more func @test_user
- [ ] #5 Refactor a bit @test_user
- [ ] #6 hogehoge @test_user"

In this PR, we've done blah blah blah ...

When we release, we should do blah blah blah ...

Or

- [ ] #1 Init new func @test_user
- [ ] #2 Add new func @test_user

In this PR, we've done blah blah blah ...

When we release, we should do blah blah blah ...

- [ ] #3 Fix bugs @test_user
- [ ] #4 Add more func @test_user
- [ ] #5 Refactor a bit @test_user
- [ ] #6 hogehoge @test_user"

Now I'm trying to fix merge_pr_body method to return my expected result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant