Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Aggregate labels from pull requests #54

Open
ohbarye opened this issue Sep 20, 2020 · 1 comment · May be fixed by #97
Open

[Proposal] Aggregate labels from pull requests #54

ohbarye opened this issue Sep 20, 2020 · 1 comment · May be fixed by #97

Comments

@ohbarye
Copy link
Collaborator

ohbarye commented Sep 20, 2020

Hello maintainers. @motemen @onk

If possible, I hope this gem would have a feature that determines labels to be added to a created pull request by aggregating labels on merged pull requests.

Feature

Let's say we have 3 merged pull requests as follows.

  1. a pull request with a label: ["enhancement"]
  2. a pull request with labels: ["bug", "security"]
  3. a pull request without any label: []

Then, a pull request that git-release-pr creates would have labels: ["enhancement", "bug", "security"].

Implementation design

  • Add pr-release.aggregate_labels config.
    • It accepts boolean-ish value: "true" or "false"
    • The default is "false"
    • If it is "true", git-release-pr aggregates labels from merged pull requests.
  • What if pr-release.labels is given at the same time?
    • Merge aggregated labels and pr-release.labels setting.
      • pr-release.labels=foo,bar and aggregated labels are baz, then labels would be ["foo", "bar", "baz"].

If it's acceptable for this gem, I'm willing to make a pull request for this feature.

@onk
Copy link
Collaborator

onk commented Sep 21, 2020

It looks reasonable and the design looks good 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants