Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set brand colors for icons / logos #32

Open
orjank11 opened this issue Mar 3, 2023 · 1 comment
Open

Set brand colors for icons / logos #32

orjank11 opened this issue Mar 3, 2023 · 1 comment

Comments

@orjank11
Copy link

orjank11 commented Mar 3, 2023

This should perhaps not be fixed in this library,

But how would people use the color of the logos for Google and Microsoft that have multiple colors in their logo.

import {
FaBrandsMicrosoft,
FaBrandsGoogle,
} from "solid-icons/fa";

Both of these icons are one single path in the svg. meaning it's least really hard to set the colors correct.

@x64Bits
Copy link
Owner

x64Bits commented Jun 1, 2023

The way the icons are currently built tries to make the final icons lightweight for the web, hence most of them are paths, SVGO is used for that, really that process it happens during the construction of this package, this also helps to be able to apply styles uniformly without worrying about SVG elements with default colors.

But I definitely understand the need for this, I've found myself needing to use custom icons to achieve this, I'm not sure if the CustomIcon component serves this purpose as well, you can take a look at it if you like, greetings and thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants