Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quality-Information in Video-Listing #172

Open
stemei2013 opened this issue Nov 11, 2018 · 5 comments
Open

Add Quality-Information in Video-Listing #172

stemei2013 opened this issue Nov 11, 2018 · 5 comments
Labels
enhancement Feature requests

Comments

@stemei2013
Copy link

Hi there,

when you see the videos listed, for example on porntrex, you see the title and then the duration like

"Title of the Video (10:19)"

Would it be possible to add some Quality-Information to this line?

Like

"Title of the Video - Full HD - (10:19)"
"Title of the Video - HD - (12:12)"

or

"Title of the Video - 1080p - (10:19)"
"Title of the Video - 720p - (10:19)"
"Title of the Video - 4k - (10:19)"

Doesn´t matter to me which info comes first, duration or quality

This way one could avoid choosing any of the non-HD videos in the first place (for example with a 4k TV everything below 720p is pretty useless).

Or, alternatively add something to the settings like "minimum quality" and an option like "720p" and everything below that won´t be even listed at all.

Thanks and keep up the great work
SteMei

@mrdougquaid mrdougquaid added the enhancement Feature requests label Nov 13, 2018
@Gujal00
Copy link
Contributor

Gujal00 commented Nov 15, 2018

Not possible with current code base as you can have only one title and one title.append
Currently title.append is used to pick up duration as it is available on almost all websites.
Very few sites mention the quality available on the main page, is it worth the effort?

The other style of information which you asked above listing multiple qualities along with the title is not possible unless the particular video page is opened and parsed for qualities. This would mean that for page with 50 videos, you have to open every page of those videos parse the qualitites and then display. This will make the addon totally unusable as each list page will take forever to render

@stemei2013
Copy link
Author

Hello,

first, thanks for responding and I appreciate the great work you do with the videodevil plugin.

I understand that the second part of my question is not possible.

Regarding displaying the video quality.
I am not that much into programming so it wasn´t clear to me that the general code base avoids displaying a second information next to the title.

Regarding websites displaying the video quality, I just checked 2 of the sites with huge content like daftsex or yespornplease and both are displaying the quality on the main page just like porntrex does.

But I must admit that I hardly use any other site than porntrex on Videodevil as many of the other sites have a majority of very short clips in (at least partially bad quality) so I don´t watch these. But taste is different and others might not watch porntrex at all.

Regarding your question wether or not its worth the effort.
As I don´t know how much the effort is (in time) to change the codebase to add a second title.apend I can´t answer that.
I guess if it´s a matter of 5 minutes it would be worth it, if it´s 5 hours probably not, however as it´s your time anyway and not mine I am not in the position to judge on this it all.

It might also depend on wether or not you plan to add sites like daftsex or yespornplease to the plugin. The more sites you add which have the quality displayed, the more it makes sense I guess to use this information and change the code for that.

Thanks a lot again and keep up the good work

SteMei

@Gujal00
Copy link
Contributor

Gujal00 commented Nov 16, 2018

The base code of videodevil is 12 years old. It is written in a style that is hard to decipher as most of it is written in the style of C instead of pythonic style. So adding enhancements such as the one you request is pretty hard for me atleast, may be @mrdougquaid can help

@nabilbendafi
Copy link
Contributor

A huge code refactor in perspective.

@imurreflection
Copy link

Alternatively, from Video Devil settings options, you can set default quality to high and it will display only the highest quality. As far as I know, Porntrex only show high quality content where in Quality selector, if you get two High qualities, the first one will be 720 and the other one will be 1080p or higher. Hope, this helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests
Projects
None yet
Development

No branches or pull requests

5 participants