New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't store the host into the list unless the users actually input something #148

Open

xcv58 opened this issue Aug 23, 2020 · 1 comment

Owner

xcv58 commented Aug 23, 2020

More detail requirement in #145 (comment)

Owner Author

xcv58 commented Aug 23, 2020

It seems a little tricky because the data loading depends on the host in the list:

Custom-JavaScript-for-Websites-2/src/js/stores/AppStore.tsx

Line 137 in 34babeb

return this.init({ domain, isRegex, pattern })

return this.init({ domain, isRegex, pattern })

On the line if the matchedHost is undefined, it just updated the host list and recall the init which call the background to read the data again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment