Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snappy is built with debug assertions enabled #342

Closed
zcronix opened this issue Aug 29, 2022 · 1 comment · Fixed by #386
Closed

Snappy is built with debug assertions enabled #342

zcronix opened this issue Aug 29, 2022 · 1 comment · Fixed by #386

Comments

@zcronix
Copy link

zcronix commented Aug 29, 2022

The source files pulled in from google/snappy make use of assert() for debugging, which are expected to be disabled in release builds when following their cmake build process by the presence of -DNDEBUG in the CXXFLAGS.

This flag is not specified for building those files as part of snappy-java. As a result, we discovered (due to a bug in our software) that it is possible to trigger failures of those assertions when using snappy-java, which terminates the process instead of propagating an exception back to Java code.

@xerial
Copy link
Owner

xerial commented Jan 28, 2023

Good catch. Testing it at #386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants