Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint is not ignoring vendor #229

Closed
jakub300 opened this issue Jul 25, 2017 · 6 comments
Closed

Stylelint is not ignoring vendor #229

jakub300 opened this issue Jul 25, 2017 · 6 comments
Labels

Comments

@jakub300
Copy link
Collaborator

It's related to update of gulp-stylelint to v4 and stylelint itself to v8.

@luboskmetko if you have a moment please set gulp-stylelint to 3.9.0, update lockfiles and relase update.

@jakub300 jakub300 added the bug label Jul 25, 2017
@luboskmetko
Copy link
Member

luboskmetko commented Jul 25, 2017

I was testing this with stylelint CLI v8 and it seems to respect our .stylelintignore

Could anything here olegskl/gulp-stylelint@3.9.0...master could be causing it? I can revert version back to 3.9.0 but would like to also submit an issue to gulp-stylelint or stylelint

@luboskmetko
Copy link
Member

Just for a reference - stylelint CLI command for testing in Chisel

stylelint "src/styles/**/*.scss" --config .stylelintrc.yml

@luboskmetko
Copy link
Member

Created an issue here olegskl/gulp-stylelint#85

@luboskmetko
Copy link
Member

Temporary fix in projects generated with the current Chisel release

yarn add gulp-stylelint@3.9.0

or

npm install gulp-stylelint@3.9.0 --save-dev

@jakub300
Copy link
Collaborator Author

Hey, I've asked for locked release because I had no time to debug. Stylelint had some changes to ignoring in v8 so probably something doesn't play nice with gulp-stylelint. If you have a moment it would be nice to create example (without chisel) and add it in the issue you created.

@luboskmetko
Copy link
Member

@jakub300 I'll make a new Chisel release by tomorrow if there is no feedback from the gulp-stylelint author. In the meanwhile we have a temporary fix listed here.

Btw. what you meant by updating lockfiles. We don't have lockfiles in generated project, do we?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants