Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React grid layout upgrade #3546

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

React grid layout upgrade #3546

wants to merge 3 commits into from

Conversation

leogretz2
Copy link
Contributor

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@leogretz2 leogretz2 self-assigned this Dec 4, 2023
@leogretz2 leogretz2 linked an issue Dec 4, 2023 that may be closed by this pull request
Update reactGridLayout -> 1.4.4 #3526
Open
@leogretz2
Copy link
Contributor Author

leogretz2 commented Dec 4, 2023 •
edited

Removed the window resizing workaround as mentioned in the associated issue. (This merged PR solves the problem.)

@haynesjm42
Copy link
Member

Thanks for taking care of this!

One thing I was excited for in this release was the ability to resize from the left and top sides without the weird behavior of it actually shrinking/growing always from the right and bottom sides - we might want to try that out and consider changing the default resizeHandles we are seeing on the props to include all sides instead of just right and bottom

@lbwexler
Copy link
Member

Hi @ghsolomon -- Can you update this to version 1.4.4 and ensure bugs are fixed and everything in order?
Would like to merge and close this out after today's role release.

@ghsolomon
Copy link
Contributor

Hi @ghsolomon -- Can you update this to version 1.4.4 and ensure bugs are fixed and everything in order? Would like to merge and close this out after today's role release.

Took a look at this, and v.1.4.4 has that bad bug we were seeing that caused widgets to snap to the top-left corner upon any drag action.

Here is a link to the (currently still open) issue: react-grid-layout/react-grid-layout#1990

@lbwexler lbwexler marked this pull request as draft January 24, 2024 02:33
@lbwexler
Copy link
Member

Converting this to DRAFT -- will revisit as soon as we get a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcclain amcclain Awaiting requested review from amcclain

@haynesjm42 haynesjm42 Awaiting requested review from haynesjm42

Assignees

@ghsolomon ghsolomon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update reactGridLayout -> 1.4.4
4 participants
@leogretz2 @haynesjm42 @lbwexler @ghsolomon