Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial uncommitted records do not get validated #3609

Open
saba-mo opened this issue Mar 21, 2024 · 2 comments
Open

Initial uncommitted records do not get validated #3609

saba-mo opened this issue Mar 21, 2024 · 2 comments

Comments

@saba-mo
Copy link
Contributor

saba-mo commented Mar 21, 2024

While working on a client app that uses store validation, it appeared that if records were already uncommitted (calling gridModel.store.addRecords() right after calling gridModel.loadData()), then they were not getting validated. Adding await wait() before adding records seems to fix the timing issue with when the StoreValidator is created.

The StoreValidator has a reaction that tracks uncommittedRecords, and we should look into firing immediately.

Reproduced in toolbox - see branch validateUncommittedRecords: https://github.com/xh/toolbox/tree/validateUncommittedRecords

@saba-mo
Copy link
Contributor Author

saba-mo commented Mar 21, 2024

Screenshots from Toolbox branch.

The first screenshot shows the initial row not appearing invalid. The second screenshot is after clicking the Add button, which then validates both records and shows the appropriate invalid display.

@saba-mo
Copy link
Contributor Author

saba-mo commented Mar 21, 2024

Screenshot 2024-03-21 at 3 27 29 PM
Screenshot 2024-03-21 at 3 27 38 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants