Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid agOptions prop is not reactive #3654

Open
ghsolomon opened this issue May 9, 2024 · 0 comments
Open

Grid agOptions prop is not reactive #3654

ghsolomon opened this issue May 9, 2024 · 0 comments
Labels

Comments

@ghsolomon
Copy link
Contributor

Currently, agOptions provided to aGrid component via props are read and cached when the component first mounts. This is unintuitive, since typically components react to observable prop changes.

For example, in a client-app, users are presented with an input to toggle the domLayout prop between normal and autoHeight; however, in order to actually achieve this, theGrid needs to be remounted to force the agOptions to be read again.

A couple possible solution:

  1. Stop caching agOptions so they are reactive like most other props. (We could do this by making agOptions a computed getter on GridLocalModel.)
  2. Make agOptions a readonly property of GridModel to more clearly communicate its immutability (does not solve the application issue described above)
@ghsolomon ghsolomon added the grid label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant