Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept children prop instead of/besides the text prop #80

Open
heokhe opened this issue May 11, 2021 · 2 comments
Open

Accept children prop instead of/besides the text prop #80

heokhe opened this issue May 11, 2021 · 2 comments

Comments

@heokhe
Copy link

heokhe commented May 11, 2021

I think this would be neater to write:

<LinesEllipsis>
  Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aenean tempus dolor at felis varius euismod. Nulla non augue at est consequat fermentum. Integer id scelerisque ipsum. Vestibulum vitae dui augue. Vivamus diam nulla, ultricies quis lacus in, pretium interdum quam. Donec non commodo orci. Nulla imperdiet scelerisque faucibus. Quisque eget metus at arcu dapibus faucibus nec eget est. Curabitur consectetur posuere ante nec mattis. Cras non posuere orci. Maecenas pellentesque massa efficitur egestas posuere. Proin efficitur urna sed turpis tincidunt, a elementum dui semper. Morbi ultricies dignissim scelerisque. Integer dignissim mauris nec arcu vestibulum, nec rhoncus nisi suscipit. Quisque tincidunt scelerisque metus, in sollicitudin metus malesuada tempor.

  In nec lectus iaculis, tristique felis at, faucibus arcu. Aliquam et euismod arcu, non semper sapien. Maecenas lobortis, mi eget hendrerit ullamcorper, lorem purus fermentum orci, non rhoncus risus mauris in odio. Aenean ut nisl purus. Fusce quis ultricies diam, at ullamcorper libero. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Etiam eget nibh eros. Aliquam semper porta massa.
</LinesEllipsis> 

than this:

<LinesEllipsis text={`Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aenean tempus dolor at felis varius euismod. Nulla non augue at est consequat fermentum. Integer id scelerisque ipsum. Vestibulum vitae dui augue. Vivamus diam nulla, ultricies quis lacus in, pretium interdum quam. Donec non commodo orci. Nulla imperdiet scelerisque faucibus. Quisque eget metus at arcu dapibus faucibus nec eget est. Curabitur consectetur posuere ante nec mattis. Cras non posuere orci. Maecenas pellentesque massa efficitur egestas posuere. Proin efficitur urna sed turpis tincidunt, a elementum dui semper. Morbi ultricies dignissim scelerisque. Integer dignissim mauris nec arcu vestibulum, nec rhoncus nisi suscipit. Quisque tincidunt scelerisque metus, in sollicitudin metus malesuada tempor.

In nec lectus iaculis, tristique felis at, faucibus arcu. Aliquam et euismod arcu, non semper sapien. Maecenas lobortis, mi eget hendrerit ullamcorper, lorem purus fermentum orci, non rhoncus risus mauris in odio. Aenean ut nisl purus. Fusce quis ultricies diam, at ullamcorper libero. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Etiam eget nibh eros. Aliquam semper porta massa.`} />
@WORLDI
Copy link

WORLDI commented Sep 2, 2021

I agree too.

@AndrejGajdos
Copy link

This feature would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants