Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NextJS compability #38

Open
alexfrancavilla opened this issue Jul 17, 2021 · 2 comments
Open

NextJS compability #38

alexfrancavilla opened this issue Jul 17, 2021 · 2 comments
Assignees
@xiaody
Labels
dependencies Pull requests that update a dependency file

Comments

@alexfrancavilla
Copy link

Hi, I was really looking forward to using this plugin instead of my selfmade piece of garbage that I produced. However, a bug in react-spring v8 is triggering compiler errors in NextJS > 9. The bug was fixed in react-spring v9 (see here).

Is there any realistic chance to get an upgrade to the latest major version of react-spring in the near future?
@xiaody
Copy link
Owner

xiaody commented Jul 20, 2021 •
edited

Last time when I checked react-spring@9.x, there was some weird issues making this component not work. I'll try to take another look this week. PR is welcomed too.

@xiaody xiaody added the dependencies Pull requests that update a dependency file label Jul 20, 2021
@xiaody
Copy link
Owner

xiaody commented Jul 24, 2021

react-touch-carousel@0.10.2 is published with latest react-spring dependency.

The single component Spring in react-spring@8 has been split into two parts in react-spring@9, i.e., Spring and animated. This causes a bit trouble for our component. The current code is kinda hacky and a refactoring may be the next necessary step.

@xiaody xiaody self-assigned this Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaody xiaody

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xiaody @alexfrancavilla