Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: defaultProps is deprecated #733

Merged
merged 1 commit into from May 30, 2023
Merged

fix: defaultProps is deprecated #733

merged 1 commit into from May 30, 2023

Conversation

wengtad
Copy link
Contributor

@wengtad wengtad commented May 18, 2023

closes #730

@SanderRuusmaa
Copy link

Necessary fix, the owner of the repo should look into this PR to keep react-image-gallery from becoming "deprecated".

@xiaolin
Copy link
Owner

xiaolin commented May 30, 2023

@wengtad thanks for opening a pr!

@xiaolin xiaolin merged commit cc46995 into xiaolin:master May 30, 2023
@aleksanderd
Copy link

what about ImageGallery?
https://github.com/xiaolin/react-image-gallery/blob/83d48d8168bb418936eae8e9465c8cff98ad1d17/src/ImageGallery.js#L1601C1-L1601C13

@saloavalos saloavalos mentioned this pull request Jul 18, 2023
Open
xiaolin pushed a commit that referenced this pull request Jul 21, 2023
@wengtad
fix: defaultProps is deprecated (#733)
437a8f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React 18.2 defaultProps error
4 participants
@wengtad @SanderRuusmaa @xiaolin @aleksanderd