Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Allow to set a rootDir in untool #1155

Open
KnisterPeter opened this issue Apr 20, 2020 · 0 comments
Open

[RFC] Allow to set a rootDir in untool #1155

KnisterPeter opened this issue Apr 20, 2020 · 0 comments

Comments

@KnisterPeter
Copy link
Contributor

Current status

Right now untool deduces the rootDir from the found (from pwd and up) package.json.
From this process the configuration is loaded using cosmiconfig. This part is not overridable.

Problem

This behaviour is a bit too static.
The first issues arose during unit testing where we currently need to spawn the test in a separate process.
On a broader view this right now prevents integrating untool in a programatic way where the scope is not the current directory. E.g. initalize an untool instance as part of a program where the start-folder should not be the current directory.

Solution

It would be good to set the rootDir from outside and respect this during each and every initialize step (cosmiconfig, webpack, ...)

Additional Info

Moved from untool/untool#488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant