Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From normalize: Line-height should be 1.5 to comply the WCAG guideline #147

Closed
thomashockaday opened this issue Oct 28, 2022 · 2 comments · Fixed by #175
Closed

From normalize: Line-height should be 1.5 to comply the WCAG guideline #147

thomashockaday opened this issue Oct 28, 2022 · 2 comments · Fixed by #175
Labels
💻 aspect: code Concerns the software code in the repository EddieHub:good-first-issue Good first issue for EddieHubCommunity/good-first-issue-finder ⭐ goal: addition Addition/Improvement of feature good first issue New-contributor friendly

Comments

@thomashockaday
Copy link

Original issue in Normalize: necolas/normalize.css#864

Particularly the bit about Turkish characters is interesting.

The guideline in question: https://www.w3.org/WAI/WCAG21/Understanding/text-spacing.html

Currently using 1.15 in this repo (https://github.com/resetercss/reseter.css/blob/main/css/reseter.css#L10)

@GaryHilares
Copy link
Contributor

Just as an update, it seems like the right link where the line-height property is being used now is this one.

@gptkrsh
Copy link
Collaborator

gptkrsh commented Jan 13, 2023

That line-height not for the normal text, it is for the sub and super script:

https://github.com/krshoss/gardevoir/blob/main/src/components/text.scss#L14-L19

But this is there in: https://github.com/krshoss/gardevoir/blob/main/src/components/global.scss#LL10

If anyone is interested for contributing please change the

line-height: 1.15

with

line-height: 1.5

Marking this as a gfi

@gptkrsh gptkrsh added ⭐ goal: addition Addition/Improvement of feature 💻 aspect: code Concerns the software code in the repository good first issue New-contributor friendly EddieHub:good-first-issue Good first issue for EddieHubCommunity/good-first-issue-finder labels Jan 13, 2023
@gptkrsh gptkrsh linked a pull request Jan 18, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository EddieHub:good-first-issue Good first issue for EddieHubCommunity/good-first-issue-finder ⭐ goal: addition Addition/Improvement of feature good first issue New-contributor friendly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants