Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flake8 #160

Closed
mbanth opened this issue Oct 14, 2022 · 1 comment · Fixed by #159
Closed

Fix flake8 #160

mbanth opened this issue Oct 14, 2022 · 1 comment · Fixed by #159
Assignees
@mbanth
Labels
size:S Small issue or pull request type:cleanup Clean up the code base

Comments

@mbanth
Copy link
Contributor

mbanth commented Oct 14, 2022

Recent CI runs of the develop branch show a failure when running flake8, which checks Python scripts for good style. Currently we pin flake8 at v3.8.3. Flake8 uses importlib-metadata. A known issue in importlib-metadata breaks flake8. By pinning importlib-metadata at v4.13.0, flake8 can run as normal.

In passing, this issue also covers an update of the XMOS Jenkins Shared Library to the latest available version, v0.20.0.
@mbanth mbanth added size:S Small issue or pull request type:cleanup Clean up the code base labels Oct 14, 2022
@mbanth mbanth self-assigned this Oct 14, 2022
@mbanth mbanth mentioned this issue Oct 14, 2022
Merged
@mbanth
Copy link
Contributor Author

mbanth commented Oct 14, 2022

Fixed by #159.

@mbanth mbanth closed this as completed Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbanth mbanth

Labels
size:S Small issue or pull request type:cleanup Clean up the code base
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update versions mbanth/lib_agc
1 participant
@mbanth