Require Node.js 8 and ESLint 6 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scttcper
changed the title
sindresorhus
reviewed
Nov 8, 2019
|
|
||
| const fixture = `'use strict';\nconst x = true;\n\nif (x) {\n console.log();\n}\n`; | ||
|
|
||
| function runEslint(str, conf) { | ||
| const linter = new eslint.CLIEngine({ | ||
| useEslintrc: false, | ||
| configFile: tempWrite.sync(JSON.stringify(conf)) | ||
| configFile: path.join(__dirname, conf) |
There was a problem hiding this comment.
Why this change? It was more elegant when you could just pass the config as an object.
There was a problem hiding this comment.
I really wasn't able to get that to work on eslint 6. Because the file created was located in the "temp" directory /temp/something it couldn't find the node_modules folder to use the eslint configs listed under extends.
sindresorhus
changed the title
|
Thanks :) |
zckrs
added a commit
to radiofrance/eslint-config-radiofrance
that referenced
this pull request
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated everything to the latest versions let me know if you would rather i match eslint-config-xo https://github.com/xojs/eslint-config-xo/blob/master/package.json#L55-L62
Currently, this package warns peerdependency when using eslint 6
Adds testing in node 12 and removes 6
BREAKING CHANGE: changes the minimum node version to 8 in package.json