Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make capitalized-comments rule ignore webpack magic comments #63

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Make capitalized-comments rule ignore webpack magic comments #63

merged 2 commits into from
Jun 10, 2020

Conversation

yangmingshan
Copy link
Contributor

Fix #62

@sindresorhus
Copy link
Member

What other magic Webpack comments are there? If none, then I would be more specific in the regex.

@yangmingshan
Copy link
Contributor Author

All webpack magic comments starts with webpack, so I just add webpack.

  • webpackInclude
  • webpackExclude
  • webpackChunkName
  • webpackMode
  • webpackPrefetch
  • webpackPreload
  • webpackIgnore

sindresorhus
sindresorhus reviewed Jun 10, 2020
View reviewed changes
index.js Outdated Show resolved Hide resolved
@yangmingshan @sindresorhus
Make regex more specific
d5883cd 
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@sindresorhus sindresorhus merged commit a0ae8d2 into xojs:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

capitalized-comments ignore webpack magic comments
2 participants
@yangmingshan @sindresorhus