-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work with the latest version of XO #91
Comments
|
As far as I can tell, xojs/xo#534 introduced some change to XO's config resolver, which in turn broke the logic that loads the XO library. |
@lolPants is right, the version just before |
Hi @Richienb, this issue is very much related to xojs/xo#543.
Then it throws when trying to load |
ESLint is only able to resolve plugins from the same node_modules folder that it is installed in or the node_modules of the project directory its Could the |
It could but makes this plugin useless. Also makes linting so much harder. |
Yeah, that is definitly the issue, The issue is not when linting files, but when loading the package. |
For those seeking a workaround until this is otherwise resolved, you can use xo v0.39.1, the most recent working version: npm install xo@0.39.1 --save-dev or the equivalent shorter command: npm i xo@0.39.1 -D If you want to see xo's description of what's in the last few releases: https://github.com/xojs/xo/releases/ |
added this issue here for visibility: xojs/xo#563 @SamVerschueren can we get any confirmation on if this extension is dead or alive? It doesn't look like its had any real activity in 2 years. Should we look for a new solution for vscode integration? |
Is there anyone here that would like to fix this for money? I am willing to pay. |
Willing to monetarily support an update to this, as well. |
@yakov116 has funded $20.00 to this issue.
|
An anonymous user has funded $20.00 to this issue.
|
@yakov116 |
@tusbar has funded $20.00 to this issue.
|
I forked and published this package as a new extension - since it seems this is no longer being maintained or accepting PRs. Please try this via the link below, and feel free to file issues in my fork. My extension should work now for all versions of XO. @tusbar @yakov116 @savearray2 -- if you have any problems definitely let me know and I will try to fix right away. https://marketplace.visualstudio.com/items?itemName=spence-s.linter-xo |
@spence-s |
@spence-s your extension works perfect ly! @SamVerschueren can you merge the PR? If it does not get merged in the next week I will credit you the bounty. |
closed by #94 |
Can you try to link the pull request? If this does not work I will email them |
@SamVerschueren I think you may have to reward it since your the repository owner. @spence-s I will send them an email now. If they don't get back to me in a prompt matter, I will send it to u via PayPal etc. |
@yakov116 feel free to email me @ sasnyde2@gmail.com if you need anything else from my end. Will try to stop spamming these threads here 😄 - but thanks for your support on this. |
Not entirely sure how this works. I'll check tomorrow on my computer. I tried linking the PR, not sure if that did it... |
I think you have to go onto issue hunt and award it there |
@samverschueren has rewarded $54.00 to @spence-s. See it on IssueHunt
|
Yes. I found it :). Great work everyone! |
Failed to load XO library. Make sure XO is installed in your workspace folder using 'npm install xo' and then press Retry.
The text was updated successfully, but these errors were encountered: