New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XO should not lint type definition files in a non-TS project #348
Comments
Sounds a good idea. |
It causes a lot of problems with non-TS project that have type definition files and non-TS projects that have TS fixture files. See #348
I decided to remove the extensions for now. They cause a lot of problems and I'm not sure what the correct solution is.
We actually cannot easily check whether the typescript parser is included as we would have to resolve the whole |
I think a better solution is this: eslint/eslint#10828 (Please vote on it) |
@sindresorhus this can be closed since #426 was merged right? |
Many CommonJS (non-TS) projects have a TS type definition file, like
index.d.ts
and it currently has to be manually ignored because XO tries to lint it: https://travis-ci.org/sindresorhus/delay/jobs/418345973How should we handle this? I don't think users should be forced to manually ignore type definition files.
We could ignore files ending in
.d.ts
unless the user hastypescript-eslint-parser
?The text was updated successfully, but these errors were encountered: