Add --print-config flag
#529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Apr 18, 2021
cli-main.js
Outdated
| if (options.stdin) { | ||
| if (options.printConfig) { | ||
| if (input.length > 0) { | ||
| console.error('The `print-config` option must be used with exactly one file name'); |
There was a problem hiding this comment.
Suggested change
| console.error('The `print-config` option must be used with exactly one file name'); | |
| console.error('The `--print-config` flag must be used with exactly one filename'); |
There was a problem hiding this comment.
This message is confusing as it makes it sound like the user passed multiple filenames to --print-config.
There was a problem hiding this comment.
That’s exactly the mistake this is intended to catch: xo --print-config x.js y.js. (This is parsed as {flags: {printConfig: 'x.js'}, input: ['y.js']}, but a user who writes that probably doesn’t know that.)
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Co-authored-by: teehemkay <tmk@exidia.com> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
commented
Apr 18, 2021
|
Looks good. Thank you 👍 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often find myself needing this option to figure out which rules XO is using. If I learn about a new ESLint rule, I want to be able to check whether XO already enables it or something similar; if I upgrade XO, I want to be able to check whether it disabled any rules I was relying on; I want to be able to check that I configured
overridescorrectly and that it’s applied in the order I expect; etc.This was largely based on #312 by @teehemkay.