Relative 'extends' no longer error out in the XO VS Code extension, nor if running XO from a different folder #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow relative 'extends' when starting XO from a folder different than the config file. This can also occur when using the XO VS Code extension. Fixes xojs#685
|
// @spence-s |
|
@sindresorhus - this is not related to recent changes, I don't believe. If I am understanding right, this is about extending the configuration from a relative dir -- it's always resolved from @andrewdbond this is probably a good solution/fix but I would like to see a failing test or 2 added so this problem won't sneak back in later and we can clearly see the use case being solved. |
|
Added to ./test/, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative 'extends' no longer error out in the XO VS Code extension, nor if running XO from a different folder.
Fixes #685
Addressed issue by altering the existsSync call. By default node:fs resolves paths relative to the directory returned by process.cwd. For the XO VS Code extension, process.cwd() references the VS Code program folder.