Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the logo #689

Closed
LitoMore opened this issue Sep 4, 2022 · 5 comments · Fixed by #692
Closed

Question about the logo #689

LitoMore opened this issue Sep 4, 2022 · 5 comments · Fixed by #692

Comments

@LitoMore
Copy link
Contributor

LitoMore commented Sep 4, 2022

Hi XO team! I'm submitting our XO logo to https://github.com/simple-icons/simple-icons.

As you can see in simple-icons/simple-icons#7749.

The icon in a badge looks not so good. May I increase the stroke-width base on your design for badges? And the ❤️ shape we could make it filled. Like this below:

Before After
CleanShot 2022-09-05 at 02 45 37@2x CleanShot 2022-09-05 at 03 17 28@2x
@sindresorhus
Copy link
Member

Yes, you should definitely increase the stroke-width when used in a smaller format like this. 👍

@LitoMore
Copy link
Contributor Author

LitoMore commented Sep 21, 2022

Now XO is available on https://shields.io.

Here are some examples:









![](https://shields.io/badge/code_style-5ed9c7?logo=xo&logoColor=black&logoSize=auto&logoWidth=20)
![](https://shields.io/badge/code_style-5ed9c7?logo=xo&labelColor=gray&logoSize=auto&logoWidth=20)
![](https://shields.io/badge/code_style-5ed9c7?logo=xo&labelColor=555&logoSize=auto&logoWidth=20)
![](https://shields.io/badge/code_style-eee?logo=xo&logoColor=black&labelColor=5ed9c7&logoSize=auto&logoWidth=20)
![](https://shields.io/badge/code_style-555?logo=xo&logoColor=black&labelColor=5ed9c7&logoSize=auto&logoWidth=20)
![](https://img.shields.io/github/actions/workflow/status/xojs/xo/main.yml?logo=xo&logoColor=black&label=code%20style&labelColor=5ed9c7&logoSize=auto&logoWidth=20)
![](https://img.shields.io/github/actions/workflow/status/xojs/xo/main.yml?logo=xo&logoColor=black&label=code%20style&labelColor=5ed9c7&color=555&logoSize=auto&logoWidth=20)
![](https://img.shields.io/github/actions/workflow/status/xojs/xo/main.yml?logo=xo&logoColor=black&label=&labelColor=5ed9c7&color=555&logoSize=auto&logoWidth=20)
![](https://img.shields.io/github/actions/workflow/status/xojs/xo/main.yml?logo=xo&label=&labelColor=gray&logoSize=auto&logoWidth=20)

@sindresorhus
Copy link
Member

Very nice! Would you be interested in submitting a PR to update https://github.com/xojs/xo#badge ?

@LitoMore
Copy link
Contributor Author

@sindresorhus Sure. Which one do you prefer?

@sindresorhus
Copy link
Member

The second one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants