Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing on macos-latest fails with Java 8 #1919

Closed
galtm opened this issue Apr 26, 2024 · 5 comments · Fixed by #1922
Closed

Testing on macos-latest fails with Java 8 #1919

galtm opened this issue Apr 26, 2024 · 5 comments · Fixed by #1922

Comments

@galtm
Copy link
Collaborator

galtm commented Apr 26, 2024

The failure commented on in #1918 (comment) looks like actions/setup-java#625 .

Based on links from that issue 625 to other GitHub issues/PRs, I see two resolutions that different repos are using (at least temporarily):

A) Using zulu distribution instead of temurin for macOS
B) Requesting macos-13 instead of macos-latest

@galtm
Copy link
Collaborator Author

galtm commented Apr 26, 2024

@cmarchand : Do you have any thoughts on the best solution for this repo?

For reference: List of distributions supported by setup-java

@galtm
Copy link
Collaborator Author

galtm commented Apr 26, 2024

You asked:

Where is the script source for this build ?

This is the configuration file for the test workflow:

https://github.com/xspec/xspec/blob/master/.github/workflows/test.yml

@cmarchand
Copy link
Collaborator

There no JDK 8 available for MacOs ARM : https://adoptium.net/temurin/releases/?version=8&os=mac&arch=arm&package=jdk

I don't know if it's new or not. Probably not.

And I'm not able to find if macos-latest runner is a Intel or an Arm.

We probably should add a uname -a in the build process, before installing Java, to check this. Maybe GitHub has changed its default infra recently...

@cmarchand
Copy link
Collaborator

Ok, it's now on M1, Arm. So yes, it's the same problem than actions/setup-java#625.

I'm reluctant to use an old MacOs OS version.

I'd prefer using either :

@galtm
Copy link
Collaborator Author

galtm commented Apr 27, 2024

Your idea of sticking to macos-latest while picking a different distribution, with Bell Liberica as the first choice, sounds good to me. I can try that in the coming week (probably imitating the syntax in https://github.com/apache/logging-parent/pull/169/files except with liberica instead of zulu), but if you want to pursue this yourself, feel free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants