-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for decorations to change cell foreground and background #3775
Merged
+660
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IColor is needed for the minimum contrast ratio function currently.
This was referenced Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3770
This new feature works by swapping out the the background and foreground colors of the cell. This is slightly different depending on the renderer especially wrt getting the correct cache key to use which is why caching of decoration override glyphs isn't supported at all for the canvas renderer.
Notice how the text is white:
Current API shape:
Note the API doesn't allow changing the colors currently as that's not actually a requirement for the search addon.
Remaining work:
IDecorationService
to get decorations at a cell to reduce code duplicationIDecorationService
and utilize it to go from O(n) to O(log n) when iterating over decorations of a lineDeferred from the PR:
Other issues fixed:
Terminal.reset()