Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini Map preview disappeared in 12.0.0-next.18 #4279

Closed
dAN0n opened this issue May 15, 2024 · 1 comment
Closed

Mini Map preview disappeared in 12.0.0-next.18 #4279

dAN0n opened this issue May 15, 2024 · 1 comment
Assignees
Labels

Comments

@dAN0n
Copy link

dAN0n commented May 15, 2024

Describe the Bug

Hi,
I suppose mini map preview was somehow broken after upgrade from 12.0.0-next.17 to 12.0.0-next.18. Zooming and dragging works but without any elements inside, just gray square with white viewport.

Your Example Website or App

https://stackblitz.com/edit/vitejs-vite-2bl2pz?file=src%2FApp.jsx

Steps to Reproduce the Bug or Issue

  1. The bug is visible in example app
  2. On xyflow/react 12.0.0-next.17 mini map works as intended.

Expected behavior

Mini map has a graph preview.

Screenshots or Videos

12.0.0-next.18
puush-linux+(2024-05-15+at+02 27 08)
12.0.0-next.17
puush-linux+(2024-05-15+at+02 27 54)

Platform

  • OS: Ubuntu 20.04.4 LTS
  • Browser: Firefox 125.0.3, Chrome 123.0.6312.86
  • Version: 12.0.0-next.18

Additional context

No response

@peterkogo peterkogo self-assigned this May 16, 2024
@peterkogo peterkogo added the v12 label May 16, 2024
@peterkogo
Copy link
Member

You forgot to add onNodesChange and onEdgesChange handler. Plus, the nesting you are doing is not recommended and will result in weird side effects. Here is a corrected sanbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants