Prevent sync operations from becoming async #36

yaacovCR · 2020-01-13T18:43:14Z

See #33 and https://github.com/apollographql/graphql-tools/pull/1057/files.

delegateToSchema should only return a promise when the configured executor/subscriber requires async work., e.g. not with execution via a local subschema.

Similarly, when not merging fields, handleObject should not convert lists of results to lists of promises to results,. Even when merging fields, given the above change, conversion to lists of promises to results should only be performed when necessary, i.e. when merging must be async.

delegateToSchema now returns a synchronous result when possible rather than always returning a promise. merging types is also performed synchronously when possible. Fixes #36.

yaacovCR closed this as completed in cb61a36 Jan 15, 2020

yaacovCR mentioned this issue Jan 15, 2020

Did not fetch typename for object, unable to resolve interface #33

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent sync operations from becoming async #36

Prevent sync operations from becoming async #36

yaacovCR commented Jan 13, 2020 •

edited

Prevent sync operations from becoming async #36

Prevent sync operations from becoming async #36

Comments

yaacovCR commented Jan 13, 2020 • edited

yaacovCR commented Jan 13, 2020 •

edited